Skip to content

[PWG-LF] add MC task#6419

Merged
njacazio merged 8 commits into
AliceO2Group:masterfrom
njacazio:nj-mcpred2
Jun 8, 2024
Merged

[PWG-LF] add MC task#6419
njacazio merged 8 commits into
AliceO2Group:masterfrom
njacazio:nj-mcpred2

Conversation

@njacazio

@njacazio njacazio commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator
  • add particle IDs

@njacazio
[PWG-LF] add MC task
c8f594b 
- add particle IDs
@njacazio njacazio mentioned this pull request Jun 7, 2024
Closed
@njacazio njacazio enabled auto-merge (squash) June 7, 2024 12:02
alibuild
alibuild previously approved these changes Jun 7, 2024
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio disabled auto-merge June 7, 2024 12:45
@njacazio njacazio enabled auto-merge (squash) June 7, 2024 12:45
alibuild
alibuild previously approved these changes Jun 7, 2024
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild alibuild mentioned this pull request Jun 7, 2024
Merged
@njacazio
Merge pull request #31 from alibuild/alibot-cleanup-6419
91824e1 
Please consider the following formatting changes to AliceO2Group#6419
@njacazio njacazio disabled auto-merge June 7, 2024 15:42
@njacazio njacazio enabled auto-merge (squash) June 7, 2024 15:43
alibuild
alibuild previously approved these changes Jun 7, 2024
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@alibuild

alibuild commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d743c83 at 2024-06-07 18:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6419-slc7_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:68:91: error: wrong number of template arguments (3, should be 2)
/sw/SOURCES/O2Physics/6419-slc7_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:68:93: error: wrong number of template arguments (1, should be 2)
/sw/SOURCES/O2Physics/6419-slc7_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:128:9: error: 'hyield' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jun 8, 2024

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 696b9d7 at 2024-06-08 10:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/6419-slc7_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:135:26: error: non-constant condition for static assertion
/sw/SOURCES/O2Physics/6419-slc7_x86-64/0/PWGLF/Tasks/QC/mcParticlePrediction.cxx:135:26: error: 'etamin' is not a constant expression
ninja: build stopped: subcommand failed.

Full log here.

@njacazio njacazio disabled auto-merge June 8, 2024 09:11
@njacazio njacazio enabled auto-merge (squash) June 8, 2024 09:12
alibuild
alibuild previously approved these changes Jun 8, 2024
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio disabled auto-merge June 8, 2024 11:15
@njacazio njacazio enabled auto-merge (squash) June 8, 2024 11:15
alibuild
alibuild approved these changes Jun 8, 2024
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit bc014f6 into AliceO2Group:master Jun 8, 2024
@njacazio njacazio deleted the nj-mcpred2 branch June 8, 2024 11:16
GiorgioAlbertoLucia pushed a commit to GiorgioAlbertoLucia/O2Physics that referenced this pull request Jul 9, 2024
@njacazio @GiorgioAlbertoLucia
[PWG-LF] add MC task (AliceO2Group#6419)
ad3e787
echizzal pushed a commit to echizzal/O2Physics that referenced this pull request Jul 18, 2024
@njacazio @echizzal
[PWG-LF] add MC task (AliceO2Group#6419)
9b0a60c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@chiarapinto chiarapinto Awaiting requested review from chiarapinto
@BongHwi BongHwi Awaiting requested review from BongHwi
@mbombara mbombara Awaiting requested review from mbombara
@ChiaraDeMartin95 ChiaraDeMartin95 Awaiting requested review from ChiaraDeMartin95
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njacazio @alibuild